-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fixes for rustc master #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is worth noting that cargo was actually creating trait boxes that contain non-static references, so I couldn't just put 'static everywhere to appease rustc.
In |
@alexcrichton test_shell.rs actually calls |
Hm, could that change to a |
This brings in versions of upstream components with build break fixes
Calling |
I almost got ChanWriter to work, but I'm getting a hang in one of the tests unless I adjust the vector to have a precise size, which seems like it should be unnecessary, and would probably break Windows if I did it. I won't have time to look at this again until later tonight, so I left in a branch if someone else wants to pick it up: https://github.com/bkoropoff/cargo/tree/whatsit |
…richton Extending #479 to use a `'static` shell instead of a `'a` shell.
…, r=alexcrichton Extending rust-lang#479 to use a `'static` shell instead of a `'a` shell.
I'm submitting this PR for feedback, but it's not yet ready to merge. The following PRs on upstream projects need to land first:
Once these land I will update Cargo.lock and add it to the PR