Skip to content

Remove quote feature use #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Remove quote feature use #5647

merged 1 commit into from
Jun 24, 2018

Conversation

est31
Copy link
Member

@est31 est31 commented Jun 23, 2018

Quote is being removed see rust-lang/rust#46849. Follow up of @Manishearth 's #4838 which removed usages of the feature so now we only have to remove quote from the #![feature] attrs.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@est31
Copy link
Member Author

est31 commented Jun 23, 2018

r? @matklad

@ehuss
Copy link
Contributor

ehuss commented Jun 23, 2018

I'm able to reproduce the error with compiler_json_error_format about 2% of the time. I think the issue is that bar and the build script are built at the same time, and its a race as to which outputs its message first. There currently isn't a way to check json output ignoring the order, though.

@Mark-Simulacrum
Copy link
Member

You could possibly pass -j1 to Cargo, which may help with that issue...

@ehuss
Copy link
Contributor

ehuss commented Jun 23, 2018

Good idea! That seems to work, though it depends on the max-depth-first rule.

@est31
Copy link
Member Author

est31 commented Jun 23, 2018

I've force pushed an update of this PR, it's green on travis now. The error that @ehuss and @Mark-Simulacrum are talking about is separate from this PR.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2018

📌 Commit e93ad66 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 23, 2018

⌛ Testing commit e93ad66 with merge 783e78f77eb737f6baa25f33623e70e3acadfbc4...

@bors
Copy link
Contributor

bors commented Jun 23, 2018

💔 Test failed - status-travis

@est31
Copy link
Member Author

est31 commented Jun 23, 2018

@bors retry

@bors
Copy link
Contributor

bors commented Jun 23, 2018

@est31: 🔑 Insufficient privileges: not in try users

@est31
Copy link
Member Author

est31 commented Jun 23, 2018

Oh, it's managed separately for rust and cargo. I only have try rights for rust.

bors added a commit that referenced this pull request Jun 23, 2018
…mulacrum

Fix random errors in test compiler_json_error_format.

The dependencies `bar` and the build script are built at the same time, so there is a race as to which outputs its message first.

This tripped on stable (1.27) on MacOS on Travis twice on #5647 ([job 10419.2](https://travis-ci.org/rust-lang/cargo/jobs/395843646) and [job 10421.2](https://travis-ci.org/rust-lang/cargo/jobs/395925454))
@Mark-Simulacrum
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Jun 23, 2018

⌛ Testing commit e93ad66 with merge 5845464...

bors added a commit that referenced this pull request Jun 23, 2018
Remove quote feature use

Quote is being removed see rust-lang/rust#46849. Follow up of @Manishearth 's #4838 which removed usages of the feature so now we only have to remove `quote` from the `#![feature]` attrs.
@bors
Copy link
Contributor

bors commented Jun 24, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 5845464 to master...

@bors bors merged commit e93ad66 into rust-lang:master Jun 24, 2018
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants