-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove quote feature use #5647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quote feature use #5647
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
r? @matklad |
I'm able to reproduce the error with |
You could possibly pass -j1 to Cargo, which may help with that issue... |
Good idea! That seems to work, though it depends on the max-depth-first rule. |
I've force pushed an update of this PR, it's green on travis now. The error that @ehuss and @Mark-Simulacrum are talking about is separate from this PR. |
@bors r+ |
📌 Commit e93ad66 has been approved by |
⌛ Testing commit e93ad66 with merge 783e78f77eb737f6baa25f33623e70e3acadfbc4... |
💔 Test failed - status-travis |
@bors retry |
@est31: 🔑 Insufficient privileges: not in try users |
Oh, it's managed separately for rust and cargo. I only have try rights for rust. |
…mulacrum Fix random errors in test compiler_json_error_format. The dependencies `bar` and the build script are built at the same time, so there is a race as to which outputs its message first. This tripped on stable (1.27) on MacOS on Travis twice on #5647 ([job 10419.2](https://travis-ci.org/rust-lang/cargo/jobs/395843646) and [job 10421.2](https://travis-ci.org/rust-lang/cargo/jobs/395925454))
@bors retry |
Remove quote feature use Quote is being removed see rust-lang/rust#46849. Follow up of @Manishearth 's #4838 which removed usages of the feature so now we only have to remove `quote` from the `#![feature]` attrs.
☀️ Test successful - status-appveyor, status-travis |
Quote is being removed see rust-lang/rust#46849. Follow up of @Manishearth 's #4838 which removed usages of the feature so now we only have to remove
quote
from the#![feature]
attrs.