Remove fix::local_paths_no_fix, as crate_in_paths is getting stabilized.
#6068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
For beta this will need to go to the 1.30.0 branch of this repo, and for nightly the master branch here. I'd recommend deleting the one test instead of updating all tests, we test cargo on stable rust so this will likely break on CI |
eddyb
force-pushed
the
oopsie-daisy-stabilize
branch
from
1b83cc8 to
afdde60
Compare
eddyb
changed the title
#![feature(rust_2018_preview)], as it's getting stabilized.fix::local_paths_no_fix, as crate_in_paths is getting stabilized.
bors
added a commit
that referenced
this pull request
Sep 21, 2018
[beta] Remove `fix::local_paths_no_fix`, as `crate_in_paths` is getting stabilized. Beta backport of #6068. Needed for rust-lang/rust#54404 (blocking RC1). r? @alexcrichton
|
@bors: r+ |
|
📌 Commit afdde60 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 21, 2018
Remove `fix::local_paths_no_fix`, as `crate_in_paths` is getting stabilized. Needed for rust-lang/rust#54403 (blocking RC1). Ideally we'd also clean up the tests, e.g. removing `#![feature(rust_2018_preview)]` and `is_nightly` checks, but it's easier to just remove the only failing test (because it tests the feature gate is needed).
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for rust-lang/rust#54403 (blocking RC1).
Ideally we'd also clean up the tests, e.g. removing
#![feature(rust_2018_preview)]andis_nightlychecks, but it's easier to just remove the only failing test (because it tests the feature gate is needed).