Repository navigation
refactor(cc): add compile-commands feature to cc - #2025
Merged
Merged
Conversation
Since this new feature pulls in mspc and code that most won't use, and I'm preparing another PR to eliminate use of mspc and HashMap/BTreeMap, I'm going to gate this behind a feature because I think using mpsc for CompileCommandCollector is the best impl Made with the help of claude
Refactor compile_commands.rs by removing unused code and comments related to CompileCommandCollector. Adjust imports and maintain feature flags for compile-commands.
Wrap compile command assertions in a conditional compilation block.
NobodyXu
marked this pull request as draft
October 13, 2026 13:37
Removed the CompileCommand struct and its associated methods and tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this new feature pulls in mspc and code that most won't use, and I'm preparing another PR to eliminate use of mspc and HashMap/BTreeMap, I'm going to gate this behind a feature because I think using mpsc for CompileCommandCollector is the best impl
Made with the help of claude