Skip to content

Commit 2df7413

Browse files
committed
Auto merge of #2533 - jtgeibel:percent-decode-uri-path, r=JohnTitor
Bump to latest release of conduit-hyper This upstream release now percent decodes the path component but not the query string. This behavior aligns with the `civet` server. The known difference is that `conduit-hyper` does a lossy utf8 conversion while `civet` panics on invalid utf8 and closes the connection immediately. This seems like a good compromise of matching the existing behavior as closely as possible without copying the panic. I looked into fixing the panic in `civet`, however the `to_str_slice` function returns an `Option<&str>` and there is nowhere to store a newly allocated `String` so changing the behavior there is not practical. r? @JohnTitor cc #2204 conduit-rust/conduit-hyper@v0.3.0-alpha.3...v0.3.0-alpha.4
2 parents 44f5639 + 58bdab9 commit 2df7413

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

Cargo.lock

+3-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ conduit-router = "0.9.0-alpha.2"
7575
conduit-static = "0.9.0-alpha.3"
7676
conduit-git-http-backend = "0.9.0-alpha.2"
7777
civet = "0.12.0-alpha.3"
78-
conduit-hyper = "0.3.0-alpha.3"
78+
conduit-hyper = "0.3.0-alpha.4"
7979
http = "0.2"
8080

8181
futures-util = "0.3"

0 commit comments

Comments
 (0)