Bump to latest release of conduit-hyper #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upstream release now percent decodes the path component but not the query string. This behavior aligns with the `civet` server. The known difference is that `conduit-hyper` does a lossy utf8 conversion while `civet` panics on invalid utf8 and closes the connection immediately. This seems like a good compromise of matching the existing behavior as closely as possible without copying the panic. I looked into fixing the panic in `civet`, however the `to_str_slice` function returns an `Option<&str>` and there is nowhere to store a newly allocated `String` so changing the behavior there is not practical. conduit-rust/conduit-hyper@v0.3.0-alpha.3...v0.3.0-alpha.4
7 tasks
|
@bors r+ |
|
📌 Commit 58bdab9 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream release now percent decodes the path component but not the
query string. This behavior aligns with the
civetserver. The knowndifference is that
conduit-hyperdoes a lossy utf8 conversion whilecivetpanics on invalid utf8 and closes the connection immediately.This seems like a good compromise of matching the existing behavior as
closely as possible without copying the panic. I looked into fixing the
panic in
civet, however theto_str_slicefunction returns anOption<&str>and there is nowhere to store a newly allocatedStringso changing the behavior there is not practical.
r? @JohnTitor
cc #2204
conduit-rust/conduit-hyper@v0.3.0-alpha.3...v0.3.0-alpha.4