Skip to content

Commit d766128

Browse files
committed
Auto merge of #1787 - rye:update-description, r=sgrif
Adjust branding to reflect what crates.io actually does To be clear that crates.io is a Rust package registry—in fact the _default_ crate host for Rust---this commit changes the `name`, `short_name`, and `description` fields in the manifest to reflect the nature of the project. crates.io isn't really "Cargo", so it seems logical to me to not mention much about it, at least in the metadata for the site. I also more explicitly mention that `crates.io` is the "default" package registry to be a bit more neutral; it's the baked-in default in Cargo, but there are others out there. I got the branding "Rust Package Registry" from the tagline in the visible top bar on the landing page. Also, update the various acceptance tests that I found floating around. Should resolve #1777, I think.
2 parents 25b52da + fcd6703 commit d766128

File tree

7 files changed

+14
-14
lines changed

7 files changed

+14
-14
lines changed

app/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<meta http-equiv="X-UA-Compatible" content="IE=edge">
66
<meta name="viewport" content="width=device-width, initial-scale=1">
77

8-
<title>Cargo: packages for Rust</title>
8+
<title>crates.io: Rust Package Registry</title>
99

1010
{{content-for 'head'}}
1111

app/templates/application.hbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{head-layout}}
22

3-
{{title "Cargo: packages for Rust" separator=' - ' prepend=true}}
3+
{{title "crates.io: Rust Package Registry" separator=' - ' prepend=true}}
44
{{google-jsapi}}
55

66
<nav id="header">

config/manifest.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
module.exports = function(/* environment, appConfig */) {
44
return {
5-
name: 'Cargo: packages for Rust',
6-
short_name: 'Cargo',
7-
description: 'Cargo is the package manager and crate host for Rust.',
5+
name: 'crates.io: Rust Package Registry',
6+
short_name: 'crates.io',
7+
description: 'crates.io is the default crate host for Rust.',
88
start_url: '/',
99
display: 'standalone',
1010
background_color: '#3b6837',

tests/acceptance/crate-test.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ module('Acceptance | crate page', function(hooks) {
6666
await click('[data-test-just-updated] [data-test-crate-link="0"]');
6767

6868
assert.equal(currentURL(), '/crates/nanomsg');
69-
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
69+
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');
7070
});
7171

7272
test('visiting /crates/nanomsg', async function(assert) {
@@ -78,7 +78,7 @@ module('Acceptance | crate page', function(hooks) {
7878

7979
assert.equal(currentURL(), '/crates/nanomsg');
8080
assert.equal(currentRouteName(), 'crate.index');
81-
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
81+
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');
8282

8383
assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
8484
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('0.6.1');
@@ -93,7 +93,7 @@ module('Acceptance | crate page', function(hooks) {
9393

9494
assert.equal(currentURL(), '/crates/nanomsg/');
9595
assert.equal(currentRouteName(), 'crate.index');
96-
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
96+
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');
9797

9898
assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
9999
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('0.6.1');
@@ -108,7 +108,7 @@ module('Acceptance | crate page', function(hooks) {
108108

109109
assert.equal(currentURL(), '/crates/nanomsg/0.6.0');
110110
assert.equal(currentRouteName(), 'crate.version');
111-
assert.equal(document.title, 'nanomsg - Cargo: packages for Rust');
111+
assert.equal(document.title, 'nanomsg - crates.io: Rust Package Registry');
112112

113113
assert.dom('[data-test-heading] [data-test-crate-name]').hasText('nanomsg');
114114
assert.dom('[data-test-heading] [data-test-crate-version]').hasText('0.6.0');

tests/acceptance/crates-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ module('Acceptance | crates page', function(hooks) {
3939
await click('[data-test-all-crates-link]');
4040

4141
assert.equal(currentURL(), '/crates');
42-
assert.equal(document.title, 'Crates - Cargo: packages for Rust');
42+
assert.equal(document.title, 'Crates - crates.io: Rust Package Registry');
4343
});
4444

4545
test('visiting the crates page directly', async function(assert) {
@@ -49,7 +49,7 @@ module('Acceptance | crates page', function(hooks) {
4949
await click('[data-test-all-crates-link]');
5050

5151
assert.equal(currentURL(), '/crates');
52-
assert.equal(document.title, 'Crates - Cargo: packages for Rust');
52+
assert.equal(document.title, 'Crates - crates.io: Rust Package Registry');
5353
});
5454

5555
test('listing crates', async function(assert) {

tests/acceptance/front-page-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module('Acceptance | front page', function(hooks) {
2525
await visit('/');
2626

2727
assert.equal(currentURL(), '/');
28-
assert.equal(document.title, 'Cargo: packages for Rust');
28+
assert.equal(document.title, 'crates.io: Rust Package Registry');
2929

3030
assert.dom('[data-test-install-cargo-link]').exists();
3131
assert.dom('[data-test-all-crates-link]').exists();

tests/acceptance/search-test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module('Acceptance | search', function(hooks) {
3030
await triggerEvent('[data-test-search-form]', 'submit');
3131

3232
assert.equal(currentURL(), '/search?q=rust');
33-
assert.equal(document.title, "Search Results for 'rust' - Cargo: packages for Rust");
33+
assert.equal(document.title, "Search Results for 'rust' - crates.io: Rust Package Registry");
3434

3535
assert.dom('[data-test-heading]').hasText("Search Results for 'rust'");
3636
assert.dom('[data-test-search-nav]').hasText('Displaying 1-8 of 8 total results');
@@ -53,7 +53,7 @@ module('Acceptance | search', function(hooks) {
5353
await visit('/search?q=rust');
5454

5555
assert.equal(currentURL(), '/search?q=rust');
56-
assert.equal(document.title, "Search Results for 'rust' - Cargo: packages for Rust");
56+
assert.equal(document.title, "Search Results for 'rust' - crates.io: Rust Package Registry");
5757

5858
assert.dom('[data-test-search-input]').hasValue('rust');
5959
assert.dom('[data-test-heading]').hasText("Search Results for 'rust'");

0 commit comments

Comments
 (0)