Adjust branding to reflect what crates.io actually does #1787
Conversation
To be clear that crates.io is a Rust package registry---in fact the _default_ crate host for Rust---this commit changes the name, short_name, and description fields in the manifest to reflect the nature of the project. crates.io isn't "Cargo", so it seems logical to me to not mention much about it, at least in the metadata for the site. I got the branding "Rust Package Registry" from the tagline in the visible top bar on the landing page. Also, update the various acceptance tests that I found floating around. Signed-off-by: Kristofer Rye <[email protected]>
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Oops! I didn't inspect my diff very closely. Signed-off-by: Kristofer Rye <[email protected]>
|
@jtgeibel This looks rather uncontroversial to me – it makes the branding in the title match the branding we already have at the top of the page. The code changes look fine to me, so maybe we can merge this? |
|
Looks good to me. +1 for merging. |
|
@bors r+ |
|
📌 Commit fcd6703 has been approved by |
Adjust branding to reflect what crates.io actually does To be clear that crates.io is a Rust package registry—in fact the _default_ crate host for Rust---this commit changes the `name`, `short_name`, and `description` fields in the manifest to reflect the nature of the project. crates.io isn't really "Cargo", so it seems logical to me to not mention much about it, at least in the metadata for the site. I also more explicitly mention that `crates.io` is the "default" package registry to be a bit more neutral; it's the baked-in default in Cargo, but there are others out there. I got the branding "Rust Package Registry" from the tagline in the visible top bar on the landing page. Also, update the various acceptance tests that I found floating around. Should resolve #1777, I think.
|
☀️ Test successful - checks-travis |
To be clear that crates.io is a Rust package registry—in fact the default crate host for Rust---this commit changes the
name,short_name, anddescriptionfields in the manifest to reflect the nature of the project. crates.io isn't really "Cargo", so it seems logical to me to not mention much about it, at least in the metadata for the site.I also more explicitly mention that
crates.iois the "default" package registry to be a bit more neutral; it's the baked-in default in Cargo, but there are others out there. I got the branding "Rust Package Registry" from the tagline in the visible top bar on the landing page.Also, update the various acceptance tests that I found floating around.
Should resolve #1777, I think.