Skip to content

Error on network failure is incomprehensible #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kjgorman opened this issue Dec 17, 2015 · 3 comments · Fixed by #3442
Closed

Error on network failure is incomprehensible #240

kjgorman opened this issue Dec 17, 2015 · 3 comments · Fixed by #3442
Assignees
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@kjgorman
Copy link

Basically if you load the crates.io page but then there is some network interruption after that point, new ajax requests will begin to fail (fair enough).

When this happens an 'oops something went wrong' page is presented, including a stack trace. I guess for an open source project like this it is probably not an issue to include debug information to public users, but the error message seems like it could be more helpful.

This came up for me when the wifi at JFK started throttling after the 30 free minutes had been used up. Obviously just refreshing the page bounced me to the "buy more wifi" splash, but it seems like it wouldn't be impossible to present a more pleasant error when there's no network connectivity.

This is the error I received at the time:
screen shot 2015-12-16 at 7 57 54 pm

You can replicate (with a less insane stack trace) by using chrome network throttling to turn off network access once you've loaded the page.

@tshepang
Copy link
Member

I saw this today, also due to bad network.

@jugglerchris
Copy link

You get something very similar going to a non-existant crate, for example https://crates.io/crates/adsfadf , but it does also say "Create adsfadf does not exist" and "e is undefined". Not sure if that's a separate issue!

@dtolnay
Copy link
Member

dtolnay commented Jul 1, 2017

I filed #844 for the non-existent crate issue. I think that one is a recent regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants