Show generic flash message if crate data fails to load #3442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rethrowing the error means that it ends up creating noise on Sentry even for regular network errors.
Turbo87
added
C-enhancement ✨
Letting the error bubble up means that it ends up creating noise on Sentry even for regular network errors.
|
@bors r+ |
|
📌 Commit d71eec6 has been approved by |
|
☀️ Test successful - checks-actions |
|
This undid the fix for #141 implemented in #421 and it's a very poor UX to redirect to the home page instead of showing a 404. The 404 (or 500 in the case of network error I guess) is semantically correct and more importantly, leaves the URL alone for the user to correct a typo. Can we revert or reconsider the change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rethrowing the error means that it ends up creating noise on Sentry even for regular network errors.
Resolves #240