database: Add categories and keywords columns to the versions table#10078
Merged
Conversation
LawnGnome
approved these changes
Nov 28, 2024
7ab9b80 to
bfc120d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10078 +/- ##
==========================================
- Coverage 89.37% 89.37% -0.01%
==========================================
Files 294 294
Lines 31283 31289 +6
==========================================
+ Hits 27960 27965 +5
- Misses 3323 3324 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #9998, this PR adds two new columns to the
versionsdatabase table:categoriesandkeywordsThese columns are filled with the corresponding values from the
Cargo.tomlfile when new crates/versions are published.Compared to the per-crate categories and keywords, these are not saved in dedicated
crates_categoriesandcrates_keywordstables, but just as a regular Postgres array column. The reason for this is that we don't need to find versions by category or keyword. We only need the data to set the new crate categories/keywords when the "default version" of a crate changes (will be implemented in a follow-up PR, once the data is backfilled in the database).Related: