Fix "pushObjects is not a function" error

[locks]

This is a bit of a quick patch to address the problem, we should dig some more into why it's happening.

Fixes #1099

[edit] I only checked config/environment.js for something disabling prototype extensions, and forgot to check package.json, which lists ember-disable-prototype-extensions.

[Turbo87]

this seems necessary only for myFeed due to

crates.io/app/controllers/dashboard.js

Line 52 in dc195a3

this.get('myFeed').pushObjects(versions);

[locks]

@Turbo87 my thought was let's keep it consistent. We could also do this.get('myFeed').push(...versions) if versions is a native array.

[Turbo87]

we could, but then the array observers won't get notified for new items in the array

[carols10cents]

Sorry this has taken me so long to look at-- I'm still getting _this.get(...).pushObjects is not a function on my dashboard page :-/

I'm going to see if I can get a test to fail for this...

[Turbo87]

I'm still getting _this.get(...).pushObjects is not a function on my dashboard page

even after applying this patch?

[carols10cents]

yep, on this branch

[carols10cents]

does this branch fix it for you?

[carols10cents]

Welp i just tried to make a test with a logged in user for the past few hours and i fail. Pushed my attempt to this branch, feel free to toss it if it's crap.

[Turbo87]

@carols10cents @locks I finally got around to looking into this and after a while I managed to figure out how to setup everything so that auth works locally too.

tl;dr we missed controller.set('myFeed', []); in the dashboard route file

I've fixed the instruction and pushed the fix to this PR. I've also moved your test to a separate me-test branch to make CI pass again here, but we should definitely continue to explore how to add tests for these pages.

[locks]

@carols10cents can you 👍 or merge?

[carols10cents]

Yay it works!!! Thank you!!!

bors: r+

[bors-voyager]

Build succeeded

• continuous-integration/travis-ci/push