Recently updated sort #1264
Merged
Recently updated sort #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moore3071
force-pushed
the
recently_updated_sort
branch
from
56a565d to
c0bcbf7
Compare
|
Will take care of it when I'm back from RailsConf |
|
Is there a reason we needed to introduce the |
sgrif
previously requested changes
Apr 23, 2018
src/tests/krate.rs
Outdated
| // Set the updated at column for each crate | ||
| let updated = Utc::now().naive_utc(); | ||
| update(&krate1) | ||
| .set(crates::updated_at.eq(updated - Duration::weeks(3))) |
There was a problem hiding this comment.
We don't need to do this in Rust. This can just be now - 3.weeks() (use diesel::dsl::*)
carols10cents
force-pushed
the
recently_updated_sort
branch
from
4130b9e to
cb6c362
Compare
|
I did a rebase and a force-push to avoid having to merge and then revert the Cargo.toml changes 😅 Sorry for letting this sit so long! |
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jul 21, 2018
1264: Recently updated sort r=carols10cents a=moore3071 Allow sorting by which crates were most recently updated as mentioned in #1210. The option is called 'recent-updates' in order to match the naming convention of 'recent-downloads' Co-authored-by: Brandon Moore <[email protected]> Co-authored-by: Carol (Nichols || Goulding) <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sorting by which crates were most recently updated as mentioned in #1210. The option is called 'recent-updates' in order to match the naming convention of 'recent-downloads'