Skip to content

Use ember-auto-import to import npm modules #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2019
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 17, 2019

... instead of using the complicated app.import() API

@rust-highfive
Copy link

r? @smarnach

(rust_highfive has picked a reviewer for you, use r? to override)

@locks
Copy link
Contributor

locks commented Dec 17, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 17, 2019

📌 Commit da343f5 has been approved by locks

bors added a commit that referenced this pull request Dec 17, 2019
Use `ember-auto-import` to import npm modules

... instead of using the complicated `app.import()` API
@bors
Copy link
Contributor

bors commented Dec 17, 2019

⌛ Testing commit da343f5 with merge 367d033...

@Turbo87 Turbo87 requested review from locks and removed request for locks December 17, 2019 00:37
@bors
Copy link
Contributor

bors commented Dec 17, 2019

☔ The latest upstream changes (presumably #1968) made this pull request unmergeable. Please resolve the merge conflicts.

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 17, 2019

npm... 😩

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 18, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 18, 2019

📌 Commit 31db55c has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Dec 18, 2019

⌛ Testing commit 31db55c with merge 087ec89...

bors added a commit that referenced this pull request Dec 18, 2019
Use `ember-auto-import` to import npm modules

... instead of using the complicated `app.import()` API
@bors
Copy link
Contributor

bors commented Dec 18, 2019

☀️ Test successful - checks-travis
Approved by: Turbo87
Pushing 087ec89 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants