Skip to content

Run cargo update -p web-sys --aggressive #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

JohnTitor
Copy link
Member

Mainly this updates wasm related packages and removes some packages.

r? @jtgeibel

@jtgeibel
Copy link
Member

jtgeibel commented Mar 6, 2020

This bump to web-sys is a great find! This has minimal overlap with production.

Would you mind including the output of cargo update in the commit message for future PRs? The downside of the new lockfile format is that it isn't as easy to see a glace (at the end of the old format) what the changes are. It's easy to forget to capture it, but for aggressive updates it is especially nice.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2020

📌 Commit 340ac7d has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Mar 6, 2020

⌛ Testing commit 340ac7d with merge d071a39...

@bors
Copy link
Contributor

bors commented Mar 6, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing d071a39 to master...

@bors bors merged commit d071a39 into rust-lang:master Mar 6, 2020
@JohnTitor JohnTitor deleted the update-wasm branch March 6, 2020 04:19
@JohnTitor
Copy link
Member Author

Would you mind including the output of cargo update in the commit message for future PRs?

Sure thing, next time!

bors added a commit that referenced this pull request May 11, 2020
…=JohnTitor

Bump rustc and some low-level dependencies

This bumps to the latest stable rustc on Heroku and does an aggressive update of `conduit-hyper`, `web-sys`, and `reqwest`. I have coupled these updates so that we clean the build cache once while also updating some low-level dependencies. In particular, this bumps crates like `libc`, `cc`, and `serde` that would result in large rebuilds anyway.

I believe it is safe to couple these updates because these crates have been bumped in the recent past without issue. See #2213 and #2246. The commit message show details of the updated versions in each step.

r? @JohnTitor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants