Use http types from http crate
#2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also pushing this to staging for some testing there. The deploy should finish within the next 15 minutes. (The deployed SHA is available in the site metadata which can be used to confirm staging still points to the latest commit in this PR, currently |
JohnTitor
approved these changes
Apr 7, 2020
JohnTitor
reviewed
Apr 7, 2020
| req.header( | ||
| // Needed for the error message we generate | ||
| // FIXME: Simplify once we hit `conduit-test 0.9.0-alpha.2` | ||
| header::HeaderName::from_lowercase(b"x-request-id").unwrap(), |
There was a problem hiding this comment.
It'd be nice the http crate had that header..
There was a problem hiding this comment.
Awesome! Thanks for opening the upstream PR.
|
@bors r=JohnTitor |
|
📌 Commit 6985639 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream conduit crates, I've dropped the custom HTTP related types in favor of types from the
httpcrate. This reduces the amount of code to maintain upstream and generally provides a cleaner API, such as namedStatusCode::*constants instead of naked integers.This should also make it easier and more efficient to support both
civetandhyperas web servers, as they (and our middleware stack) now use the same types and avoid unnecessary conversions.r? @JohnTitor