Remove unnecessary this.get() calls
#2776
Conversation
| @@ -26,7 +26,7 @@ export default Controller.extend({ | |||
| keywords: alias('crate.keywords'), | |||
| categories: alias('crate.categories'), | |||
| isOwner: computed('crate.owner_user', 'session.currentUser.id', function () { | |||
| return this.get('crate.owner_user').findBy('id', this.get('session.currentUser.id')); | |||
| return this.crate.owner_user.findBy('id', this.session.currentUser?.id); | |||
There was a problem hiding this comment.
none of these are async relationships?
There was a problem hiding this comment.
hmm, good question, some of them actually are 🤔
|
☔ The latest upstream changes (presumably #2802) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
|
@Turbo87 you have some conflicts here |
|
yeah, I'm aware. closing this for now :) |
Turbo87
force-pushed
the
get
branch
2 times, most recently
from
4eb20de to
60cfbcf
Compare
|
@locks I've rebased this and checked the references to async relationships. Those that are relevant are covered by tests and are still working fine after this change. |
|
Looking sharp! @bors r+ |
|
📌 Commit 21d2bc3 has been approved by |
|
☀️ Test successful - checks-travis |
These should not be necessary anymore AFAICT
Resolves #1795
r? @locks