Skip to content

Show the word "rust" on crate detail page #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2016

Conversation

wlonk
Copy link
Contributor

@wlonk wlonk commented Aug 27, 2016

This is a crude jamming in of the word, but maybe it'll suffice, or at least start a conversation about what would be better.

Fixes #369.

Every pull request should come with a cute animal picture:

seal

@alexcrichton
Copy link
Member

Thanks! Could you show a screenshot of the change as well?

@wlonk
Copy link
Contributor Author

wlonk commented Aug 28, 2016

Here it is:

screenshot 2016-08-27 23 51 42

@alexcrichton
Copy link
Member

cc @rust-lang/docs

Thoughts on this?

@GuillaumeGomez
Copy link
Member

Don't find it very useful... Otherwise, don't have a strong opinion on this change.

@wlonk
Copy link
Contributor Author

wlonk commented Aug 29, 2016

@GuillaumeGomez: It was intended to address the issue raised in #369, which I believe was for SEO purposes?

@steveklabnik
Copy link
Member

I feel torn. I agree we can do better on SEO here, but I'm not sure if this is the best way to do it, or if it does it at all. Do we have a citation for this being a good idea, other than "Putting "rust" on the page is likely to make it more relevant"?

@wlonk
Copy link
Contributor Author

wlonk commented Aug 29, 2016

@steveklabnik I have no confidence that this actually helps SEO, but I wanted to get that ticket moving, to either a fixed or wontfix state. I am very very open to better suggestions.

@GuillaumeGomez
Copy link
Member

To add "rust" in the searches, you should better put it <title> or keywords add a title under Cargo which says something like "All rust crates in one place" (just an idea).

@peschkaj
Copy link

For this to help SEO, "Rust" should be in the title, a header element on the page, a description meta tag, and ideally somewhere in the body. Source: Google's SEO optimization starter guide.

To get the most out of SEO, I think a plan of attack should be developed based on existing material (e.g. the Google SEO optimization guide).

@wlonk
Copy link
Contributor Author

wlonk commented Aug 29, 2016

@peschkaj Thanks, that's very helpful. I'll read that, and propose something.

@wlonk
Copy link
Contributor Author

wlonk commented Aug 30, 2016

OK, per that document, there are three particularly relevant principles:

Create unique, accurate page titles

I propose changing the stable part of the page titles from "Cargo" to "Cargo: packages for Rust" or "Cargo: Crates for Rust"

Make use of the "description" meta tag

I propose adding a description meta tag (perhaps using ember-cli-meta-tags) to crate detail pages that will include the title (" - Cargo: packages for Rust") and the crate description (or at least the beginning of it?)

Use heading tags appropriately

We could change the brand h1, which currently says simply "CARGO", to say "CARGO: Packages for Rust". That makes a big visible change, so I'd especially appreciate input on this idea.

I'd love thoughts on this!

@steveklabnik
Copy link
Member

I like 1 and 2, I just merged #423 which helps with 1 a bit, but could probably be tightened up for SEO purposes.

3 seems like a big, user visible change, yeah. I wonder if through some CSS magic, it could go below, in smaller type? Hm.

@peschkaj
Copy link

On 3, I bet we could through a span in there and work some typographical magic to do @steveklabnik's idea.

👍

@ducks
Copy link

ducks commented Aug 30, 2016

Whoops. Didn't see this had diverged to talk about meta descriptions too.

I started a PR for this over at #427.

I added the ember-cli-meta-tags package and setup a meta tag for the index route. It looks pretty easy to add more to any page we need.

@wlonk wlonk force-pushed the say-rust-on-crate-page branch from 6c17158 to 9f6f234 Compare August 30, 2016 21:33
@wlonk
Copy link
Contributor Author

wlonk commented Aug 30, 2016

@rjgoldsborough Ah, duplication, sorry! I just did the same stuff in this branch!

@alexcrichton
Copy link
Member

Oh oops, sorry @wlonk! I merged #427 but it looks like this has some more bits? Want to rebase this and keep this so we can merge?

@wlonk wlonk force-pushed the say-rust-on-crate-page branch from 58c13e7 to a069ead Compare August 31, 2016 17:02
@wlonk
Copy link
Contributor Author

wlonk commented Aug 31, 2016

Totally.

@alexcrichton
Copy link
Member

Thanks @wlonk!

@alexcrichton alexcrichton merged commit c3895e3 into rust-lang:master Sep 1, 2016
@wlonk wlonk deleted the say-rust-on-crate-page branch September 1, 2016 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants