-
Notifications
You must be signed in to change notification settings - Fork 643
Show the word "rust" on crate detail page #415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks! Could you show a screenshot of the change as well? |
cc @rust-lang/docs Thoughts on this? |
Don't find it very useful... Otherwise, don't have a strong opinion on this change. |
@GuillaumeGomez: It was intended to address the issue raised in #369, which I believe was for SEO purposes? |
I feel torn. I agree we can do better on SEO here, but I'm not sure if this is the best way to do it, or if it does it at all. Do we have a citation for this being a good idea, other than "Putting "rust" on the page is likely to make it more relevant"? |
@steveklabnik I have no confidence that this actually helps SEO, but I wanted to get that ticket moving, to either a fixed or wontfix state. I am very very open to better suggestions. |
To add "rust" in the searches, you should better put it |
For this to help SEO, "Rust" should be in the title, a header element on the page, a description meta tag, and ideally somewhere in the body. Source: Google's SEO optimization starter guide. To get the most out of SEO, I think a plan of attack should be developed based on existing material (e.g. the Google SEO optimization guide). |
@peschkaj Thanks, that's very helpful. I'll read that, and propose something. |
OK, per that document, there are three particularly relevant principles: Create unique, accurate page titles I propose changing the stable part of the page titles from "Cargo" to "Cargo: packages for Rust" or "Cargo: Crates for Rust" Make use of the "description" meta tag I propose adding a description meta tag (perhaps using ember-cli-meta-tags) to crate detail pages that will include the title (" - Cargo: packages for Rust") and the crate description (or at least the beginning of it?) Use heading tags appropriately We could change the brand I'd love thoughts on this! |
I like 1 and 2, I just merged #423 which helps with 1 a bit, but could probably be tightened up for SEO purposes. 3 seems like a big, user visible change, yeah. I wonder if through some CSS magic, it could go below, in smaller type? Hm. |
On 3, I bet we could through a 👍 |
Whoops. Didn't see this had diverged to talk about meta descriptions too. I started a PR for this over at #427. I added the |
6c17158
to
9f6f234
Compare
@rjgoldsborough Ah, duplication, sorry! I just did the same stuff in this branch! |
This is a crude jamming in of the word, but maybe it'll suffice. Fixes rust-lang#369.
This reverts commit 00cfeac.
58c13e7
to
a069ead
Compare
Totally. |
Thanks @wlonk! |
This is a crude jamming in of the word, but maybe it'll suffice, or at least start a conversation about what would be better.
Fixes #369.
Every pull request should come with a cute animal picture: