Wrap instead of hiding crate list sections on mobile. #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late response but thanks for the PR! Want to rebase over some recent changes and then I'll merge? |
utkarshkukreti
force-pushed
the
wrap-not-hide-crate-list-sections
branch
from
1ce3333 to
7d6c051
Compare
|
@alexcrichton done! I've tried to make sure the fixes in #453 were not broken in my update:
cc @rjgoldsborough |
utkarshkukreti
force-pushed
the
wrap-not-hide-crate-list-sections
branch
from
7d6c051 to
2ebc428
Compare
|
Thanks! |
|
👍 How often is code from this repo deployed to crates.io? |
|
I need to manually do so, but I'll do so now. |
bors
added a commit
that referenced
this pull request
Dec 18, 2019
…r-7.0.0, r=Turbo87 Bump ember-resolver from 4.2.4 to 7.0.0 Bumps [ember-resolver](https://github.com/ember-cli/ember-resolver) from 4.2.4 to 7.0.0. <details> <summary>Release notes</summary> *Sourced from [ember-resolver's releases](https://github.com/ember-cli/ember-resolver/releases).* > ## v7.0.0 > #### 💥 Breaking Change > * [#452](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/452) Remove dead module unification code ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🚀 Enhancement > * [#450](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/450) remove now defunct v8 optimization ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🐛 Bug Fix > * [#475](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/475) Fix babel-plugin-debug-macros warning ([@​hjdivad](https://github.com/hjdivad)) > > #### Committers: 2 > - David J. Hamilton ([@​hjdivad](https://github.com/hjdivad)) > - Stefan Penner ([@​stefanpenner](https://github.com/stefanpenner)) > > > ## v6.0.2 > * Re-release v6.0.0, to avoid SemVer issue with removal of module unification support within 6.x. > > ## Release 6.0.1 > #### 💥 Breaking Change > * [#452](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/452) Remove dead module unification code ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🚀 Enhancement > * [#450](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/450) remove now defunct v8 optimization ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🐛 Bug Fix > * [#475](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/475) Fix babel-plugin-debug-macros warning ([@​hjdivad](https://github.com/hjdivad)) > > #### Committers: 2 > - David J. Hamilton ([@​hjdivad](https://github.com/hjdivad)) > - Stefan Penner ([@​stefanpenner](https://github.com/stefanpenner)) > > ## Release 5.3.0 > ## v5.3.0 (2019-09-24) > > #### 🚀 Enhancement > * [#417](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/417) Add support for nested colocated components. ([@​rwjblue](https://github.com/rwjblue)) > > #### Committers: 1 > - Robert Jackson ([@​rwjblue](https://github.com/rwjblue)) > > ## Release 5.2.1 > ## v5.2.1 (2019-08-09) > > #### 🐛 Bug Fix > * [#396](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/396) Component and their templates should be normalized the same. ([@​rwjblue](https://github.com/rwjblue)) > > #### Committers: 1 > - Robert Jackson ([@​rwjblue](https://github.com/rwjblue)) > ></tr></table> ... (truncated) </details> <details> <summary>Changelog</summary> *Sourced from [ember-resolver's changelog](https://github.com/ember-cli/ember-resolver/blob/master/CHANGELOG.md).* > ## v7.0.0 (2019-12-18) > > #### 💥 Breaking Change > * [#452](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/452) Remove dead module unification code ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🚀 Enhancement > * [#450](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/450) remove now defunct v8 optimization ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🐛 Bug Fix > * [#475](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/475) Fix babel-plugin-debug-macros warning ([@​hjdivad](https://github.com/hjdivad)) > > #### Committers: 2 > - David J. Hamilton ([@​hjdivad](https://github.com/hjdivad)) > - Stefan Penner ([@​stefanpenner](https://github.com/stefanpenner)) > > ## v6.0.2 (2019-12-18) > > * Re-release v6.0.0, to avoid SemVer issue with removal of module unification support within 6.x. > > ## v6.0.1 (2019-12-18) > > #### 💥 Breaking Change > * [#452](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/452) Remove dead module unification code ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🚀 Enhancement > * [#450](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/450) remove now defunct v8 optimization ([@​stefanpenner](https://github.com/stefanpenner)) > > #### 🐛 Bug Fix > * [#475](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/475) Fix babel-plugin-debug-macros warning ([@​hjdivad](https://github.com/hjdivad)) > > #### Committers: 2 > - David J. Hamilton ([@​hjdivad](https://github.com/hjdivad)) > - Stefan Penner ([@​stefanpenner](https://github.com/stefanpenner)) > > ## v6.0.0 (2019-11-19) > > #### 💥 Breaking Change > * [#449](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/449) Upgrade deps and drop node 6 support ([@​stefanpenner](https://github.com/stefanpenner)) > > #### Committers: 1 > - Stefan Penner ([@​stefanpenner](https://github.com/stefanpenner)) > > ## v5.2.1 (2019-08-09) > > #### 🐛 Bug Fix > * [#396](https://github-redirect.dependabot.com/ember-cli/ember-resolver/pull/396) Component and their templates should be normalized the same. ([@​rwjblue](https://github.com/rwjblue)) > > #### Committers: 1 > - Robert Jackson ([@​rwjblue](https://github.com/rwjblue)) > ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`9593829`](ember-cli/ember-resolver@9593829) 7.0.0 - [`be2c61a`](ember-cli/ember-resolver@be2c61a) Add v7.0.0 to CHANGELOG.md. - [`8f3c5fd`](ember-cli/ember-resolver@8f3c5fd) Add v6.0.2 to CHANGELOG.md. - [`5f07661`](ember-cli/ember-resolver@5f07661) Bump resolve from 1.13.1 to 1.14.0 - [`abbbd08`](ember-cli/ember-resolver@abbbd08) Release 6.0.1 - [`6073445`](ember-cli/ember-resolver@6073445) Add automated release setup. - [`e68934d`](ember-cli/ember-resolver@e68934d) Merge pull request [#475](https://github-redirect.dependabot.com/ember-cli/ember-resolver/issues/475) from ember-cli/hjdivad/remove-warnings - [`27e393f`](ember-cli/ember-resolver@27e393f) Fix babel-plugin-debug-macros warning - [`d948272`](ember-cli/ember-resolver@d948272) Bump @ember/optional-features from 1.1.0 to 1.2.0 - [`37dba53`](ember-cli/ember-resolver@37dba53) Bump eslint-plugin-ember from 7.7.1 to 7.7.2 - Additional commits viewable in [compare view](ember-cli/ember-resolver@v4.2.4...v7.0.0) </details> <br /> [](https://dependabot.com/compatibility-score.html?dependency-name=ember-resolver&package-manager=npm_and_yarn&previous-version=4.2.4&new-version=7.0.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in the `.dependabot/config.yml` file in this repo: - Update frequency - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently impossible to view the Just Updated and New Crates list on mobile as they are set to hide at <= 750px and <= 550px respectively. Instead of completely hiding them, I made them wrap at the same breakpoints used right now, so at <= 750px, there are 2 lists per row, and at <= 550px there is only 1 per row now.
Screenshots (after applying the changes in this PR):
At around 750px:
At around 550px:
I would really appreciate if someone can test this out to double check I didn't mess anything else.