Sort crate dependencies before adding to index #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Turbo87 merged 1 commit into rust-lang:master from arlosi:sort-deps

Apr 13, 2023

Contributor

arlosi commented Apr 12, 2023 •

edited by Turbo87

Loading

We sorted the crate dependencies when we did the normalization, but newly published crates do not get their dependencies sorted.

Updates the Ord impl on Dependency so all fields are included to ensure a total order.
Adds a test that verifies newly published crates get sorted (verified this failed before the fix).

Related:

index: Use/Allow alphabetic ordering of features and dependencies #5089

Turbo87 added C-bug 🐞 A-backend ⚙️ labels

Member

Turbo87 commented Apr 12, 2023

I'll take a close look tomorrow. Do you think it would be possible to write a regression test for this?

arlosi force-pushed the sort-deps branch from 5cd864b to 5e3b6ec Compare

April 12, 2023 19:24


          Sort crate dependencies before adding to index

9f7c9c2

Also ensure that the sorting of dependencies uses all fields.

arlosi force-pushed the sort-deps branch from 5e3b6ec to 9f7c9c2 Compare

April 12, 2023 19:25

Contributor Author

arlosi commented Apr 12, 2023

@Turbo87 Thanks. Test added.

Turbo87 approved these changes

View reviewed changes

Member

Turbo87 left a comment

looks good, thank you!

I guess that means we might have to run another normalization pass for the crates that have been published since the last time 🙈

Turbo87 merged commit aeda739 into rust-lang:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-bug 🐞