publish: Normalize dependency version requirements #7245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cargo reads a
Cargo.toml
file and sees afoo = "1.0"
dependency declaration it saves the version requirement as asemver::VersionReq
. If cargo then publishes the crate and transforms the dependency declaration to the publish metadata JSON blob it essentially usessemver::VersionReq::to_string()
which normalizes the version requirement and transforms1.0
into^1.0
.On the crates.io side we've been accepting these values from the metadata as-is and only using
VersionReq::parse()
to check if it is a valid version requirement, but there was no normalization performed.Since we now read dependency declarations directly from the embedded
Cargo.toml
file ourselves (see #7238) the normalization that cargo (unintentionally?) performed is now missing.This PR brings back the normalization with a
VersionReq::parse()
andto_string()
cycle.