-
Notifications
You must be signed in to change notification settings - Fork 643
Added badges for Is it maintained, codecov and coveralls #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@carols10cents Can you review this PR? Corresponding PR in the cargo repository: rust-lang/cargo#4038 |
Hey @carols10cents Can you retrigger the travis ci build? These errors no longer pop up locally when I do cargo test. Plus the line numbers that travis suggests has errors doesn't contain the relevant code |
I don't think Travis CI is taking the latest push for building as the error reported is: error: no associated item named But this statement has now moved to L216. Similarly, all other errors are also off by similar line counts @carols10cents What can I do to run the build with the latest code changes? |
I think the problem is that I pushed code that removed the |
Thanks @carols10cents |
ping @carols10cents, mind taking a look at this? |
Whoops, crates.io has been on my back burner lately. Will hopefully review this tonight! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, works great! Tried out all the badges locally and everything worked as I would expect 👍 👍 👍 Thank you!!!!
Adding the badges to address #705 and #706
The badges added are:
Is it maintained: Resolution time
Is it maintained: Percentage of open issues
Codecov: Code coverage
Coveralls: Code coverage