Skip to content

Added badges for Is it maintained, codecov and coveralls #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2017
Merged

Added badges for Is it maintained, codecov and coveralls #726

merged 4 commits into from
Jun 1, 2017

Conversation

nisargthakkar
Copy link
Contributor

Adding the badges to address #705 and #706

The badges added are:
Is it maintained: Resolution time
Is it maintained: Percentage of open issues
Codecov: Code coverage
Coveralls: Code coverage

@nisargthakkar
Copy link
Contributor Author

nisargthakkar commented May 13, 2017

@carols10cents Can you review this PR?

Corresponding PR in the cargo repository: rust-lang/cargo#4038

@nisargthakkar
Copy link
Contributor Author

Hey @carols10cents Can you retrigger the travis ci build? These errors no longer pop up locally when I do cargo test. Plus the line numbers that travis suggests has errors doesn't contain the relevant code

@nisargthakkar
Copy link
Contributor Author

nisargthakkar commented May 14, 2017

I don't think Travis CI is taking the latest push for building as the error reported is:

error: no associated item named update_crate_old found for type cargo_registry::Badge in the current scope
--> src/tests/badge.rs:222:5
|
222 | Badge::update_crate_old(req.tx().unwrap(), &krate, badges).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^

But this statement has now moved to L216. Similarly, all other errors are also off by similar line counts

@carols10cents What can I do to run the build with the latest code changes?

@carols10cents
Copy link
Member

I think the problem is that I pushed code that removed the Badge::update_crate_old function :-X I'm going to try fixing up your branch (since I broke it) and pushing a new commit.

@nisargthakkar
Copy link
Contributor Author

Thanks @carols10cents

@alexcrichton
Copy link
Member

ping @carols10cents, mind taking a look at this?

@carols10cents
Copy link
Member

Whoops, crates.io has been on my back burner lately. Will hopefully review this tonight!

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works great! Tried out all the badges locally and everything worked as I would expect 👍 👍 👍 Thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants