Ability to add/update user email#921

Merged

bors-voyager[bot] merged 27 commits intorust-lang:masterfrom

natboehm:add-user-email

Aug 3, 2017

Commits on Jul 28, 2017

string can be input in email field which is sent to the backend, user email field then is updated in the database
natboehm
committed
delete unsused variables
natboehm
committed
added rudimentary user email validation, has empty input error on the ember side, i think
natboehm
committed
delete ember validation import, extract email input into component
natboehm
committed
save button disabled if email field empty, odd bug where input was sometimes undefined seems to be fixed
natboehm
committed
added simple email validation
natboehm
committed
add error catch statement, fix javascript linting errors
natboehm
committed
wrap input submit with form tag
natboehm
committed
add div to wrap email field
natboehm
committed
initial basic styling on email label
natboehm
committed
basic styling for viewing and editing email field
natboehm
committed
only displays 'please add email' message when email field is currently null
natboehm
committed
display 'please add email' message only when email is not already added
natboehm
committed
Split EncodableUser into EncodablePrivateUser and EncodablePublicUser in order to try to keep user emails private, update tests to pass
natboehm
committed
fixes bug where GitHub login would update and overwrite current email stored in database
natboehm
committed
add test to put and get updates to user email, had to change GET /me to support test, for now
natboehm
committed
tests for empty email and checking that another user cannot change currently signed in user's email
natboehm
committed
add test to check for bug of GitHub login overwriting current email data updated by crates.io user
natboehm
committed
add comments to tests, delete debug println
natboehm
committed
delete unused variable
natboehm
committed
cargo fmt
natboehm
committed
delete function new_user_with_id
natboehm
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ability to add/update user email#921

Ability to add/update user email#921
bors-voyager[bot] merged 27 commits intorust-lang:masterfrom
natboehm:add-user-email

Commits on Jul 28, 2017

string can be input in email field which is sent to the backend, user email field then is updated in the database

delete unsused variables

added rudimentary user email validation, has empty input error on the ember side, i think

delete ember validation import, extract email input into component

save button disabled if email field empty, odd bug where input was sometimes undefined seems to be fixed

added simple email validation

add error catch statement, fix javascript linting errors

wrap input submit with form tag

add div to wrap email field

initial basic styling on email label

basic styling for viewing and editing email field

only displays 'please add email' message when email field is currently null

display 'please add email' message only when email is not already added

Split EncodableUser into EncodablePrivateUser and EncodablePublicUser in order to try to keep user emails private, update tests to pass

fixes bug where GitHub login would update and overwrite current email stored in database

add test to put and get updates to user email, had to change GET /me to support test, for now

tests for empty email and checking that another user cannot change currently signed in user's email

add test to check for bug of GitHub login overwriting current email data updated by crates.io user

add comments to tests, delete debug println

delete unused variable

cargo fmt

delete function new_user_with_id

Commits on Aug 2, 2017

delete commented out code

reword please add email message

simplify isEmailNull function, edit error message

delete print statement

change regex to not match on newline characters - before users could potentially add their email, then garbage on a newline, which would still evaluate as valid

Ability to add/update user email#921bors-voyager[bot] merged 27 commits intorust-lang:masterrust-lang/crates.io:masterfrom natboehm:add-user-emailnatboehm/crates.io:add-user-emailCopy head branch name to clipboard

Commits

Commits on Jul 28, 2017

Commits on Aug 2, 2017

Ability to add/update user email#921
bors-voyager[bot] merged 27 commits intorust-lang:masterfrom
natboehm:add-user-email