Add versions.edition column to the database and expose it on the API#9932
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9932 +/- ##
==========================================
+ Coverage 89.18% 89.19% +0.01%
==========================================
Files 294 295 +1
Lines 30713 30753 +40
==========================================
+ Hits 27390 27429 +39
- Misses 3323 3324 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
52eb9cb to
2577756
Compare
LawnGnome
left a comment
There was a problem hiding this comment.
👍
Note that this does not include any backfilling for previously uploaded crates. Should we move the API part to a dedicated PR and merge it only after we have backfilled the data?
Your call, but I feel like we can merge this as-is and just not tell anyone until the backfill has occurred. 🙂
2577756 to
934d3fb
Compare
the backfill has occurred 😉 the script to generate the backfill data is available at https://github.com/Turbo87/crates.io/blob/backfill/edition/src/bin/backfill-edition.rs |
This addresses part of #1541 by reading the
editionfield of uploadedCargo.tomlfiles, saving the value in the database and then exposing it on the API.Note that this does not include any backfilling for previously uploaded crates. Should we move the API part to a dedicated PR and merge it only after we have backfilled the data?
Related:
as_str()fn LukeMathWalker/cargo-manifest#58