Skip to content

Add versions.edition column to the database and expose it on the API#9932

Merged
Turbo87 merged 3 commits into
rust-lang:mainfrom
Turbo87:edition-column
Nov 19, 2024
Merged

Add versions.edition column to the database and expose it on the API#9932
Turbo87 merged 3 commits into
rust-lang:mainfrom
Turbo87:edition-column

Conversation

@Turbo87

@Turbo87 Turbo87 commented Nov 14, 2024

Copy link
Copy Markdown
Member

This addresses part of #1541 by reading the edition field of uploaded Cargo.toml files, saving the value in the database and then exposing it on the API.

Note that this does not include any backfilling for previously uploaded crates. Should we move the API part to a dedicated PR and merge it only after we have backfilled the data?

Related:

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Nov 14, 2024
@Turbo87 Turbo87 requested a review from a team November 14, 2024 13:38
Comment thread crates/crates_io_tarball/src/manifest.rs Outdated
@codecov

codecov Bot commented Nov 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (88f856d) to head (934d3fb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9932      +/-   ##
==========================================
+ Coverage   89.18%   89.19%   +0.01%     
==========================================
  Files         294      295       +1     
  Lines       30713    30753      +40     
==========================================
+ Hits        27390    27429      +39     
- Misses       3323     3324       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Turbo87 Turbo87 force-pushed the edition-column branch 3 times, most recently from 52eb9cb to 2577756 Compare November 18, 2024 16:21

@LawnGnome LawnGnome left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Note that this does not include any backfilling for previously uploaded crates. Should we move the API part to a dedicated PR and merge it only after we have backfilled the data?

Your call, but I feel like we can merge this as-is and just not tell anyone until the backfill has occurred. 🙂

@Turbo87 Turbo87 merged commit a1b9583 into rust-lang:main Nov 19, 2024
@Turbo87 Turbo87 deleted the edition-column branch November 19, 2024 05:13
@Turbo87

Turbo87 commented Nov 19, 2024

Copy link
Copy Markdown
Member Author

until the backfill has occurred

the backfill has occurred 😉

the script to generate the backfill data is available at https://github.com/Turbo87/crates.io/blob/backfill/edition/src/bin/backfill-edition.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants