Remove unnecessary redirect

[jyn514]

Once #534 gets merged, the 'Platform' dropdown will link to the default build /:crate/:version/:platform, which will immediately redirect to /:crate/:version. It would be nice to link to /:crate/:version directly for the default platform.

[jyn514]

Here's some half-working code (goes in src/web/rustdoc.rs):

    let target_links = {
        use std::collections::HashMap;
        let mut map = HashMap::new();
        for target in &crate_details.doc_targets {
            match target {
                Json::String(target) => {
                    if target == &crate_details.metadata.default_target {
                        map.insert(target, "".to_owned());
                    } else {
                        let path = format!("/{}", target);
                        map.insert(target, path);
                    }
                }
                _ => log::warn!("unknown JSON type for doc_target: {}", target),
            }
        }
        map
    };

[jyn514]

To implement this:

1. Add a target_links field to CrateDetails
2. Fill out that field using the code above (or your own code, I wrote this in a rush).
3. Use those links in the template instead of always using the {{this}} variable.

[shorsher]

I'll take a look at this, thanks for all the work outlining what needs to be done. Is double clicking on the platform drop down supposed to automatically redirect you? Right now it does not.

[jyn514]

Is double clicking on the platform drop down supposed to automatically redirect you?

I wouldn't expect it too ... you're suggesting it should take you to the default platform? I'd be ok with that.

[shorsher]

@jyn514 I think I assumed a bit too much when glancing over the issue :). I don't have a preference either way, but I'll add it as part of this PR and we can get opinions from the larger team.

[jyn514]

@pietroalbini do you think this is still worth fixing? I kind of like that it's consistent with all the other redirects, it makes it easier to reason about reading the code.