-
Notifications
You must be signed in to change notification settings - Fork 212
Make right-side menus onclick. #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One issue here is that the |
Ah, good catch. I tested this using the mobile simulator in Chrome, and tapping the "(i)" icon (which is what the "about" menu becomes) does nothing. So, this change is not ready to merge yet. I'm not sure how to make the item act as a link on mobile (or small screens), while acting to open the menu on larger screens. I'm open to ideas! |
Unfortunately I don't know enough about CSS to help you here, but @GuillaumeGomez might have ideas. |
templates/header/topbar_begin.html
Outdated
<li class="pure-menu-item pure-menu-has-children pure-menu-allow-hover pure-menu-opt-children"> | ||
<a href="/about" class="pure-menu-link"> | ||
<li class="pure-menu-item pure-menu-has-children pure-menu-opt-children"> | ||
<a href="#" class="pure-menu-link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why keeping this element then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I removed the <a>
tag and just had the text "About", clicks on "About" didn't do anything.
templates/header/topbar_begin.html
Outdated
#}<li class="pure-menu-item pure-menu-has-children pure-menu-allow-hover pure-menu-opt-children"> | ||
<a href="/releases" class="pure-menu-link"> | ||
#}<li class="pure-menu-item pure-menu-has-children pure-menu-opt-children"> | ||
<a href="#" class="pure-menu-link"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why keeping this element?
I though of a solution to the mobile problem: Right now |
Sounds like a plan :) |
Co-authored-by: Joshua Nelson <[email protected]>
Co-authored-by: Joshua Nelson <[email protected]>
I'm going to close this for now; it has conflicts and I'm not likely to pick it up again soon. |
This is followup from #1081 and #1077.
This takes the link that was the click action for each menu, and moves it to the first item in the menu.