Use the same icon for clipboard button that crates.io itself uses #1394
Conversation
notriddle
commented
May 4, 2021
•
notriddle
commented
This is, again, directly copying what rustdoc does.
|
Hmm, I'm not a giant fan of the icon rustdoc uses - maybe we could make it a clipboard for both instead? https://fontawesome.com/icons/clipboard?style=solid |
|
We don't use fontawesome in rustdoc, so the only thing I can suggest is replacing the rustdoc one with a svg so then we can use the same vector image in docs.rs. How does it sound? |
|
Yes, that sounds good :) I just think it should be a clipboard icon or something similar. |
|
I don't like much the current icon so very open to changes. :) |
|
I don't like the current icon very much either, but I like that it's a unicode character instead of an SVG. Less overhead. How about |
|
The current font rendering on mac is quite bad and broken in fact, which is why I suggested an SVG. Simpler to have a unified rendering. |
|
That seems pretty complicated for a button :/ what do you mean by bad and broken? |
|
So, are we going to import an SVG copy icon into rustdoc, or use the |
|
I'd prefer an SVG icon like we do for other icons in rustdoc. Also cc @jsha |
|
See also rust-lang/rust#84639, where @rukai helpfully posted a screenshot of how crates.io does it. I think it's really valuable to harmonize the icon and the interaction between crates.io, doc.rust-lang.org, and docs.rs. And the crates.io icon is an SVG! 🎉 |
notriddle
changed the title
|
Okay, here's the crates.io icon. |
|
cc @Nemo157 (since it's front-end ;) ) |
…o157 Use an SVG image for clipboard instead of unicode character Linked to rust-lang/docs.rs#1394. cc `@jsha` r? `@Nemo157`
This way, sighted users can see the label, too.
