Retain queries and convert :: paths on redirects to rust-lang.org
#1816
Conversation
github-actions
bot
added
the
S-waiting-on-review
There was a problem hiding this comment.
- code looks good
- tests look good
Since the coverage on redirects is relatively good I'm also certain that nothing breaks :)
Only edge-case I can think of is that if I add any query arg to this endpoint, the query won't be added: https://docs.rs/std::path?some=arg -> https://doc.rust-lang.org/stable/std/?some=arg. But IMO this doesn't matter
Manual test also works.
| @@ -155,6 +134,12 @@ pub fn rustdoc_redirector_handler(req: &mut Request) -> IronResult<Response> { | |||
| Some((krate, path)) => (krate.to_string(), Some(path.to_string())), | |||
| None => (crate_name.to_string(), None), | |||
| }; | |||
|
|
|||
| if let Some(inner_path) = DOC_RUST_LANG_ORG_REDIRECTS.get(crate_name.as_str()) { | |||
There was a problem hiding this comment.
it feels strange to put this into the rustdoc-handler, in theory we could refactor the shared behaviour into separate methods and then have separate handlers.
But since axum forbids overlapping routes contrary to iron which just takes the first matching route, we would have to merge the handlers anyways to a certain extend.
So this is OK with me.
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
fixes #751, but using
::separated paths instead of the/ones mentioned in the issue.