Left-align crate and release pages #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retain centered alignment for / and /about. Since the crate page is navigated as part of a crate's documentation, it's jarring for it to have different alignment than the documentation itself.
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jan 22, 2023
|
Big 👍 for coherency! |
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make them more similar to doc pages. Retain centered alignment for / and /about.
Since the crate page is navigated as part of a crate's documentation, it's jarring for it to have different alignment than the documentation itself.
We first made this change in 2020 but reverted it due to a regression: the about and home pages weren't supposed to change.
Now, homepage stays the same:
About stays the same:
Crate page is left aligned:
The doc page stays left aligned:
