install all used targets into the container when provisioning #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuietMisdreavus
force-pushed
the
vagrant-targets
branch
from
09d4ed5 to
f0c422f
Compare
|
Based on a conversation with @onur today, i've updated this PR to only add targets for 64-bit macOS and Windows. Adding all 8 targets starts to run into space issues when running in the vagrant container. |
|
I think this targets are enough for development. Adding all targets may slow us down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When i opened https://github.com/onur/docs.rs/pull/224, i had a problem where it couldn't generate docs for all the usual targets. I poked around again, and after adding some debug printing, it turns out that the Cargo invocation fails because it can't find the
stdto link the crate against - i.e. the target hadn't been installed in rustup. After adding the target(s) to the container, they all built just fine. This PR adds the installation of the required targets into the Vagrantfile, so that when someone provisions their environment, they get all the required targets right away.