ensure current tracing span is passed into streaming html rewrite#2874
Merged
syphar merged 1 commit intorust-lang:masterfrom Jul 29, 2025
Merged
ensure current tracing span is passed into streaming html rewrite#2874syphar merged 1 commit intorust-lang:masterfrom
syphar merged 1 commit intorust-lang:masterfrom
Conversation
github-actions
Bot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Jul 29, 2025
github-actions
Bot
added
S-waiting-on-deploy
GuillaumeGomez
removed
the
S-waiting-on-deploy
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to
Coming from these errors, where I want to see if they are flakes.
I'm also thinking of adding spans to the tokio-task & the render-in-threadpool call, but in there we don't log anything.