Skip to content

update build-time metric to be more detailed #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeGomez merged 2 commits into from
Feb 14, 2026
Merged

update build-time metric to be more detailed #3205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12494b8
update build-time metric histogram buckets
syphar Feb 14, 2026
d2e6be3
add build-result (success/fail/error) to build-time metric
syphar Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion crates/bin/docs_rs_builder/src/build_queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use docs_rs_context::Context;
use docs_rs_fastly::CdnBehaviour as _;
use docs_rs_logging::BUILD_PACKAGE_TRANSACTION_NAME;
use docs_rs_utils::{Handle, retry};
use opentelemetry::KeyValue;
use std::time::Instant;
use tracing::{error, info_span};

Expand All @@ -25,7 +26,22 @@ fn process_next_crate(
let instant = Instant::now();
let res = f(to_process);
let elapsed = instant.elapsed().as_secs_f64();
builder_metrics.build_time.record(elapsed, &[]);
builder_metrics.build_time.record(
elapsed,
&[KeyValue::new(
"result",
match &res {
Ok(summary) => {
if summary.successful {
"success"
} else {
"failed"
}
}
Err(_) => "error",
},
)],
);
res
};

Expand Down
43 changes: 22 additions & 21 deletions crates/bin/docs_rs_builder/src/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,28 @@ pub const DOCUMENTATION_SIZE_BUCKETS: &[f64; 16] = &[

/// the measured times of building crates will be put into these buckets
pub const BUILD_TIME_HISTOGRAM_BUCKETS: &[f64] = &[
30.0, // 0.5
60.0, // 1
120.0, // 2
180.0, // 3
240.0, // 4
300.0, // 5
360.0, // 6
420.0, // 7
480.0, // 8
540.0, // 9
600.0, // 10
660.0, // 11
720.0, // 12
780.0, // 13
840.0, // 14
900.0, // 15
1200.0, // 20
1800.0, // 30
2400.0, // 40
3000.0, // 50
3600.0, // 60
5.0, // 5s
10.0, // 10s
15.0, // 15s
20.0, // 20s
25.0, // 25s
30.0, // 30s
45.0, // 45s
60.0, // 1 min
90.0, // 1.5 min
120.0, // 2 min
150.0, // 2.5 min
180.0, // 3 min
210.0, // 3.5 min
240.0, // 4 min
270.0, // 4.5 min
300.0, // 5 min
420.0, // 7 min
600.0, // 10 min
900.0, // 15 min
1200.0, // 20 min
1800.0, // 30 min
3600.0, // 60 min
];

#[derive(Debug)]
Expand Down
Loading