storage: also repair on find_index calls#3319
Merged
syphar merged 1 commit intorust-lang:mainfrom May 3, 2026
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
May 3, 2026
github-actions
Bot
added
S-waiting-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing this sentry error I realized that
find_indexdoesn't have our repair-loop.We still have gaps in this "self-repair" thing: when an index file can be opened, but is broken in different ways, so
Index.findandIndex.folder_contentswould fail. (the most used one,Cache.find, which wrapsIndex.find, has repair loops).I don't like the current design here, and want to update it, but lacking time today I just want the current errors to be fixed.