-
Notifications
You must be signed in to change notification settings - Fork 212
Make search tab style match navigation #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Zexbe
commented
Feb 3, 2020
•
edited
Loading
edited
- Change the icon to use font awesome
- Use the same border the other menu items are using
I guess you tried to use "fa-search" from font-awesome. Unfortunately, it doesn't work unless you add "font-family: FontAwesome" on the element. But then, the text would change as well. So not really ideal. :) The border change looks good. |
Oh no, I solved that issue. I lost the change somehow, one second. |
Please add a screenshot too so people can see the changes. |
Okay, I added pictures for three different media sizes. |
Thanks! I'll merge once CI pass. |
Could you move the icon out of the placeholder so it's shown even when something is written in the input? |
I'm not sure how I would make that work. |
It'd be fine for me if the icon is all the way to the left. |
...and if we do that we could also left-align the input to make it less weird. |
It is done, it looks even better now. I updated the pictures |
Any objections to merging? |
Not from me. Let's wait for @pietroalbini's approval. ;) |
Okay, updated the search label |
Thanks! |