Skip to content

RFC - Migrate to asynchronous code using Hyper #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented May 5, 2020

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of migrating, and I'd go with the first migration option (having a Hyper route forwarding requests to Iron). I'd also love see in the RFC whether we want to first migrate faster, slower, less requested or more requested routes first.

Copy link
Member

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that turning a hyper request into an iron request is easy enough, this sounds like a good way to go.

@Kixiron
Copy link
Member Author

Kixiron commented May 9, 2020

Waiting on review from the following members

@jyn514
Copy link
Member

jyn514 commented May 9, 2020

Please update the RFC to address the comments, including the comments you marked as resolved.

@Nemo157
Copy link
Member

Nemo157 commented May 10, 2020

One other thought I just had is that it might be good to avoid having the actual site code rely directly on hyper by using something like http-service (though there are ecosystem issues that make me hesitant to directly recommend http-service). If there are performance issues with hyper then that decoupling would make moving to another service host easier.

@Kixiron
Copy link
Member Author

Kixiron commented May 10, 2020

I think pretty much anything we use will make for a slightly painful experience because most are fairly heavily opinionated and very different. Additionally, hyper has a pretty good relationship with the tower webstack, so if need be transferring to that probably wouldn't be too bad

@Nemo157
Copy link
Member

Nemo157 commented May 10, 2020

That was meant to be the point of http-service, it’s a (relatively) unopinionated Interface between an opinionated web framework and the underlying server; so that you can swap web servers while using the same framework (or proposed lack of framework) on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants