Skip to content

Reworked CI #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 27, 2020
Merged

Reworked CI #883

merged 4 commits into from
Jul 27, 2020

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Jul 4, 2020 •
edited
Loading

  • Made caching better, it now cleans up uneeded garbage and recovers on cache misses
  • Split testing, clippy and rustfmt into separate jobs so they can run independently and not interrupt each other
  • Added cargo-bloat-action which will comment on PRs which affect dependencies and display the current number of dependencies, what dependencies have been added/removed and the final binary size each dependency inhabits
  • Split the docker job into a separate file since it has nothing to do with the rest of the CI (it's self-contained)
  • Added healthchecks to the compose file which should make running docker-compose more seamless

r? @Nemo157

Nemo157
Nemo157 reviewed Jul 5, 2020
View reviewed changes
@Kixiron
Copy link
Member Author

Kixiron commented Jul 5, 2020

It looks like cargo-bloat lacks the permissions to comment @pietroalbini I don't know how to fix that, could you take a look?

@Kixiron Kixiron force-pushed the ci-improvements branch from 018374c to fcfd694 Compare July 5, 2020 18:07
@pietroalbini
Copy link
Member

@Kixiron I'm not seeing any error related to cargo-bloat?

@Kixiron Kixiron force-pushed the ci-improvements branch from fcfd694 to a934092 Compare July 6, 2020 14:52
@Kixiron
Copy link
Member Author

Kixiron commented Jul 6, 2020

Github linked improperly but this should work

@pietroalbini
Copy link
Member

@Kixiron that's not possible: the GITHUB_TOKEN available in PRs is read-only, and no other secret can be used in PRs.

@jyn514 jyn514 added C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 13, 2020
@jyn514
Copy link
Member

jyn514 commented Jul 26, 2020

@Nemo157 you were the main reviewer for this, are you happy with it? If so I think it can be merged after a rebase.

@jyn514 jyn514 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jul 26, 2020
@jyn514 jyn514 merged commit aef8426 into rust-lang:master Jul 27, 2020
@Kixiron Kixiron deleted the ci-improvements branch July 27, 2020 15:54
@jyn514 jyn514 mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 approved these changes

Assignees
No one assigned
Labels
C-technical-debt Category: This makes the code harder to read and modify, but has no impact on end users S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kixiron @pietroalbini @jyn514 @Nemo157