Improve logging & cexpect BuildPage.metadata #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixiron
added
S-waiting-on-review
jyn514
reviewed
Aug 15, 2020
Kixiron
force-pushed
the
nameless-faceless
branch
from
a9e727f to
ebc85f9
Compare
jyn514
reviewed
Aug 15, 2020
jyn514
reviewed
Aug 15, 2020
Co-authored-by: Joshua Nelson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes random panics with build pages, changes
WebPage::into_responseto usecexpectinstead of.unwrap()and adds file locations and the requested route toctry/cexpectloggingCloses #969