Skip to content

Pre push #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 15, 2020
Merged

Pre push #977

merged 10 commits into from
Aug 15, 2020

Conversation

ohaddahan
Copy link
Contributor

Adding pre-push git hook that runs docker-compose up -d db s3 and cargo test.

@ohaddahan ohaddahan mentioned this pull request Aug 15, 2020
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also post a screenshot of what this looks like when run?

@GuillaumeGomez
Copy link
Member

I don't have docker-compose so that would prevent me to send any PRs?

@Nemo157
Copy link
Member

Nemo157 commented Aug 15, 2020

@GuillaumeGomez git hooks are opt-in, so you'd just not set it up. I'm not planning to use them either so I have no opinion on what it does.

@ohaddahan
Copy link
Contributor Author

Screenshot as requested.

image

@jyn514 jyn514 merged commit 6ecfa71 into rust-lang:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants