Fix warnings in new nightly #1147
Conversation
|
I don't think we should do this-- as I pointed out in rust-lang/rust#52671, I think it should be fine for an empty type (like []) to be promoted and have mutable references to it shared. |
|
Ok, is promotion a guaranteed thing though? It seems odd that you could rely on it working in this case while there's no way to safely write an explicit form like static mut EMPTY: &mut [u8] = &mut [];
mem::swap(&mut self.buf, &mut EMPTY);If you want to leave this till it's hashed out on rust-lang/rust#52671 I can drop the |
|
Dropped the |
| @@ -362,7 +362,7 @@ if_std! { | |||
| ) -> Poll<Result<usize>> { | |||
| let position = self.position(); | |||
| let result = { | |||
| let mut out = self.get_mut().as_mut(); | |||
| let out = self.get_mut().as_mut(); | |||
There was a problem hiding this comment.
Can you explain why this mut is unused? It looks used to me (there's an &mut out below). Is it just because it's an &mut already and some coercion is firing?
There was a problem hiding this comment.
It’s not quite an &mut out below, it’s closer to an &mut (out[pos..]). That works fine with an immutable binding to a mutable slice since the indexing is being done via an auto-deref. (At least, I think that’s what’s going on).
Part of #1143.