Use 'self: Pin<&mut Self>' on AsyncRead/AsyncWrite #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
io-pin
branch
2 times, most recently
from
c9ba313 to
7dec9f9
Compare
taiki-e
changed the title
|
"cycle detected" error is related to rust-lang/rust#55997. |
|
This looks great, thanks so much! I'll go ahead and merge this for now, since it allows us to avoid some unnecessary allocation in the Stream -> AsyncRead shim and would allow the same in a hypothetical Sink/AsyncWrite shim, which could be extra-valuable when we get async streams / generators. If we discover people are hitting usability problems (which I don't anticipate) then we can revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1454
concerns:
Most methods of
AsyncReadExt/AsyncWriteExtrequireSelf: Unpin.Add a new dependency (pin-project).- Removed