Use #[warn(unreachable_pub)] #1615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
unreachable_pub
branch
2 times, most recently
from
f8223e7 to
9b46498
Compare
taiki-e
commented
May 19, 2019
| pub use self::StdIo::IoSlice as IoSlice; | ||
| pub use self::StdIo::IoSliceMut as IoSliceMut; | ||
| pub use self::StdIo::SeekFrom as SeekFrom; | ||
| #[allow(clippy::useless_attribute)] // https://github.com/rust-lang/rust-clippy/issues/4106 |
There was a problem hiding this comment.
This false positive has already been fixed on the master of clippy (rust-lang/rust-clippy#4107), but it may take some time for nightly to be released with this change.
|
nice! i'm actually surprised this required so few changes. I'll happily merge once conflicts are resolved here. |
|
Rebased (and Travis passed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it helps to avoid problems like #1477. (Seems there are still some false positives, but I think their impact is small)