[experiment] remove CURRENT_TASK thread-local variable #374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURRENT_TASK
was introduced in #77, a change that bundled the removal of theschedule()
method together with the removal of thetask
parameter topoll()
. There has been some discussion, e.g. in #129, about whether the latter removal has been a net win. My feeling is that is has not, and this pull request represents my attempt to see what would be involved in bringing back explicitly-passed tasks.I have not yet figured out a way to get task-local storage working with this approach, so at the moment this pull request removes
task_local!()
. I'm interested in hearing about any ideas for how we could continue to support task-local storage, or how we might design something that fills the same need.