Skip to content

Drop support for non-immovable #[async] macros #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 17, 2018
Merged

Drop support for non-immovable #[async] macros #964

merged 11 commits into from
Apr 17, 2018

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Apr 12, 2018 •
edited
Loading

Fixes #918
Subsumes #936

@Nemo157 Nemo157 mentioned this pull request Apr 12, 2018
Closed
This was referenced Apr 12, 2018
Merged
Closed
@raviqqe
Copy link
Contributor

raviqqe commented Apr 12, 2018

Personally, I like your naming of unpin. But, can boxed be box instead as unpin sounds like a verb?

@withoutboats
Copy link

How do you feel about removing the unpin/async_move feature entirely? It seems like it requires duplicating literally every API - including await - and the current version of the RFC for built-in syntax doesn't support this at all.

@Nemo157
Copy link
Member Author

Nemo157 commented Apr 16, 2018

I'm 👍 for that, I'm only using immovable futures personally. If the wider futures community is planning on skipping 0.2 for 0.3 (which has been my impression of at least tokio and hyper) I think there's less need to try and provide a compatible macro for experimenting with. I don't want to make that call though, since I'm working with quite a niche usage of futures at the moment. If you/someone makes the call I can update this PR to remove it.

@withoutboats
Copy link

delete it! 🎉

@Nemo157 Nemo157 force-pushed the consistent-async-args branch from a380a27 to 6069ea7 Compare April 16, 2018 18:23
@Nemo157 Nemo157 changed the title Use consistent macro arguments for #[async] etc. WIP: Drop support for #[async_move] etc. Apr 16, 2018
@Nemo157 Nemo157 changed the title WIP: Drop support for #[async_move] etc. Drop support for non-immovable #[async] macros Apr 16, 2018
@withoutboats
Copy link

LGTM, will merge after the tests run

@withoutboats withoutboats merged commit b8369e2 into rust-lang:master Apr 17, 2018
@Nemo157 Nemo157 mentioned this pull request Jul 27, 2018
Closed
10 tasks
@Nemo157 Nemo157 deleted the consistent-async-args branch February 16, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nemo157 @raviqqe @withoutboats