Skip to content

Fix wrong reinitialization of target_builtins #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoyo merged 1 commit into from
Apr 25, 2024
Merged

Fix wrong reinitialization of target_builtins #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions gcc/jit/dummy-frontend.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,8 +1035,6 @@ jit_end_diagnostic (diagnostic_context *context,
gcc::jit::active_playback_ctxt->add_diagnostic (context, *diagnostic);
}

static bool builtins_initialized = false;

/* Language hooks. */

static bool
Expand Down Expand Up @@ -1075,12 +1073,16 @@ jit_langhook_init (void)
eventually be controllable by a command line option. */
mpfr_set_default_prec (256);

// TODO: check if this is a good fix.
if (!builtins_initialized)
{
targetm.init_builtins ();
builtins_initialized = true;
}
// FIXME: This code doesn't work as it erases the `target_builtins` map
// without checking if it's already filled before. A better check would be
// `if target_builtins.len() == 0` (or whatever this `hash_map` type method
// name is).
// static bool builtins_initialized = false;
// if (!builtins_initialized)
// {
targetm.init_builtins ();
// builtins_initialized = true;
// }

return true;
}
Expand Down