Skip to content

Add useHttpPath support in CredentialHelper #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

arlosi
Copy link
Contributor

@arlosi arlosi commented Jan 20, 2021

Respect the useHttpPath git configuration parameter when calling the git credential helper.

@alexcrichton
Copy link
Member

Looks good to me, thanks!

@alexcrichton alexcrichton merged commit 171071d into rust-lang:master Jan 20, 2021
@sharkdp
Copy link

sharkdp commented Feb 16, 2021

This changeset uses str::strip_prefix which is only available in Rust 1.45. The git2 crate previously built fine with 1.42 (and possibly older versions).

I realize that you don't have a strict policy on this ("git2-rs works with stable Rust, and typically works with the most recent prior stable release as well"), but I thought it would be worth mentioning. Bumping the min. supported Rust version in a patch release like this breaks downstream builds (with Rust < 1.45) that simply use

git2 = "0.13"

The README also says "Check the MSRV job of the CI script to see the oldest version of Rust known to pass tests.", but I don't see an explicit requirement in https://github.com/rust-lang/git2-rs/blob/455098a8a1ce24305faf690264fc5b636d210739/.github/workflows/main.yml

Also, thank you for creating and maintaining this library - it has been a pleasure to work with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants