This repository was archived by the owner on May 23, 2024. It is now read-only.
Add up to 6 ICEs #351
Merged
Add up to 6 ICEs #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall looks good, could you drop 71805.rs since the issue has been fixed already and add a new line to the end of each file? |
|
Also needs a rebase. |
|
Do I need to squash commits? |
I'd prefer so. |
Add trailing newlines and move 71805 to fixed
|
Are 70934 and 71798 fixed as well? |
|
Oops, sorry! I mistook 71798 for 71805, the later hasn't been fixed yet. 70934 is also fixed indeed. |
|
Glad to help! Where do I go for further questions unrelated to this PR? |
If it's related to glacier, the issue tracker is one of the good places. If related to Rust itself, then we have some places, e.g. Discord, Discourse, Zulip, etc. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
71546 might need some work done on the
main()function.