-
Notifications
You must be signed in to change notification settings - Fork 6
document.c: fix trigger of -Werror=misleading-indentation #6
document.c: fix trigger of -Werror=misleading-indentation #6
Conversation
gcc 6.1.1 triggers a warning here, which breaks git rust build. There is no actual bug, because the "if" branch exits the loop, but if it wasn't so, it'd be a bug. ``` /tmp/makepkg/build/rust-git/src/rust/src/rt/hoedown/src/document.c: In function 'char_link': /tmp/makepkg/build/rust-git/src/rust/src/rt/hoedown/src/document.c:1161:5: error: this 'else' clause does not guard... [-Werror=misleading-indentation] else nb_p--; i++; ^~~~ /tmp/makepkg/build/rust-git/src/rust/src/rt/hoedown/src/document.c:1161:18: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'else' else nb_p--; i++; ```
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! |
I guess this should also be merged to master? |
Nah our submodule is pointed at this branch so it'll just need to be updated now. We don't maintain the |
Yes, you don't need to specify |
Ah, shame on me, I've forgotten how submodules work. Then the submodule pointer must be updated in rust-lang/rust to point to the new commit, correct? |
Yeah you'll just |
So I now do another PR against rust, right? // the code/communication ratio for this PR isn't even a denormal double. |
Indeed, that should do it! |
hoedown: fix trigger of -Werror=misleading-indentation See rust-lang/hoedown#6.
gcc 6.1.1 triggers a warning here, which breaks git rust build.
There is no actual bug, because the "if" branch exits the loop, but if it wasn't so, it'd be a bug.
This PR is same as #5 but against different branch, as requested by @alexcrichton.