Skip to content

critical: a try build can trigger a merge to master #47

Open
@bryanburgers

Description

@bryanburgers

It appears that sometimes, the result of a try build can trigger a merge to master. This seems to occur when the PR is approved between when the try build is started and when the Homu gets notified that the try build finished.

See: rust-lang/rust#61763 (comment)

Potential steps to reproduce (haven't tried this yet, but it fits with what happened on the referenced issue comment):

  1. Start a try build (e.g. @botname try)
  2. Approve the build (e.g. @botname r+)
  3. Wait until the try build succeeds

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions