-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Redox FD_* function-macros and Android AI_* constants #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
7a8431a
to
24fb156
Compare
The force push was just to fix a typo of not properly qualifying |
I'm not really sure why CI is failing; it just says that it's been cancelled because it ran too long but I'm not sure why that is. |
24fb156
to
aa6f5e2
Compare
@gnzlbg do you have any idea why CI might be failing? |
Closing and re-opening to re-run CI. |
@bors r+ |
📌 Commit aa6f5e2 has been approved by |
Add Redox FD_* function-macros and Android AI_* constants I'm not sure if I'm allowed to add multiple, separate APIs in the same PR, but I guess they're both for uncommon/exotic platforms? The `AI_*` constants were taken from `usr/include/netdb.h` on my Termux install; the `FD_` functions were taken from `linux_like/mod.rs`.
☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure |
I'm not sure if I'm allowed to add multiple, separate APIs in the same PR, but I guess they're both for uncommon/exotic platforms?
The
AI_*
constants were taken fromusr/include/netdb.h
on my Termux install; theFD_
functions were taken fromlinux_like/mod.rs
.