Skip to content

Add Redox FD_* function-macros and Android AI_* constants #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

coolreader18
Copy link
Contributor

I'm not sure if I'm allowed to add multiple, separate APIs in the same PR, but I guess they're both for uncommon/exotic platforms?

The AI_* constants were taken from usr/include/netdb.h on my Termux install; the FD_ functions were taken from linux_like/mod.rs.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@coolreader18 coolreader18 force-pushed the fdset-redox-ai-android branch from 7a8431a to 24fb156 Compare December 8, 2019 05:48
@coolreader18
Copy link
Contributor Author

coolreader18 commented Dec 8, 2019

The force push was just to fix a typo of not properly qualifying c_int.

@coolreader18
Copy link
Contributor Author

I'm not really sure why CI is failing; it just says that it's been cancelled because it ran too long but I'm not sure why that is.

@coolreader18 coolreader18 force-pushed the fdset-redox-ai-android branch from 24fb156 to aa6f5e2 Compare December 9, 2019 04:10
@coolreader18
Copy link
Contributor Author

@gnzlbg do you have any idea why CI might be failing?

@gnzlbg
Copy link
Contributor

gnzlbg commented Dec 23, 2019

Closing and re-opening to re-run CI.

@gnzlbg gnzlbg closed this Dec 23, 2019
@gnzlbg gnzlbg reopened this Dec 23, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented Dec 27, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Dec 27, 2019

📌 Commit aa6f5e2 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Dec 27, 2019

⌛ Testing commit aa6f5e2 with merge 74ff412...

bors added a commit that referenced this pull request Dec 27, 2019
Add Redox FD_* function-macros and Android AI_* constants

I'm not sure if I'm allowed to add multiple, separate APIs in the same PR, but I guess they're both for uncommon/exotic platforms?

The `AI_*` constants were taken from `usr/include/netdb.h` on my Termux install; the `FD_` functions were taken from `linux_like/mod.rs`.
@bors
Copy link
Contributor

bors commented Dec 27, 2019

☀️ Test successful - checks-cirrus-freebsd-10, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, status-azure
Approved by: gnzlbg
Pushing 74ff412 to master...

@bors bors merged commit aa6f5e2 into rust-lang:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants