Skip to content

Add MINSIGSTKSZ and SIGSTKSZ definitions for MacOS#1654

Merged
JohnTitor merged 1 commit intorust-lang:masterfrom
jedisct1:macos_sigstk_constants
Mar 8, 2020
Merged

Add MINSIGSTKSZ and SIGSTKSZ definitions for MacOS#1654
JohnTitor merged 1 commit intorust-lang:masterfrom
jedisct1:macos_sigstk_constants

Conversation

@jedisct1
Copy link
Contributor

@jedisct1 jedisct1 commented Feb 5, 2020

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR here, but right now there's not many maintainers to help merge this, so it may take awhile.

@bors
Copy link
Contributor

bors commented Mar 7, 2020

☔ The latest upstream changes (presumably #1642) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

Looks good! @jedisct1 could you rebase and resolve conflicts?
r? @JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned gnzlbg Mar 7, 2020
@jedisct1
Copy link
Contributor Author

jedisct1 commented Mar 7, 2020

Rebased!

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it'd be great if you could just rebase, not merge.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit 920878b into rust-lang:master Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants